Yeah, I don't have commit access -- and I've found that getting Win32 patches into llvm can be like pulling teeth sometimes (I have a few patches that are over 45 days old, and reviewed). :-(
But hopefully that process will improve as we get more Win32 developers involved in the project. ~Aaron On Wed, Oct 12, 2011 at 11:34 AM, Nikola Smiljanic <[email protected]> wrote: > What is the procedure now? Do we just wait for someone else to look at it > and commit (I'm guessing that you don't have commit access)? cfe-commits is > in the CC. > > On Tue, Oct 11, 2011 at 6:55 PM, Aaron Ballman <[email protected]> > wrote: >> >> Looks good to me! >> >> Thanks! >> >> ~Aaron >> >> On Tue, Oct 11, 2011 at 2:26 AM, Nikola Smiljanic <[email protected]> >> wrote: >> > Fixed formatting. >> > >> > On Mon, Oct 10, 2011 at 9:13 PM, Aaron Ballman <[email protected]> >> > wrote: >> >> >> >> I would still fix the code formatting even though you merely >> >> uncommented it (just to be consistent with the rest of the code). But >> >> functionally-speaking, I think your patches are good. >> >> >> >> ~Aaron >> > > > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
