On Thu, Oct 13, 2011 at 12:55:09PM -0500, Sebastian Pop wrote:
> On Thu, Oct 13, 2011 at 12:26 PM, Joerg Sonnenberger
> <[email protected]> wrote:
> > On Thu, Oct 13, 2011 at 11:51:10AM -0500, Sebastian Pop wrote:
> >> The first patch 0001-add-getDefaultTargetTriple.patch defines
> >> LLVM_DEFAULT_TARGET_TRIPLE based on the value of $target set by
> >> the configure script.  This is then used in 
> >> llvm::sys::getDefaultTargetTriple
> >> to return the triple corresponding to the target architecture.
> >
> > Please fix it to just derive LLVM_HOSTTRIPLE from $target and not $host.
> 
> I do not think this is correct: setting host from target
> will just confuse people.

Check your patch for how LLVM_HOSTTRIPLE is used... I agree that the
naming is suboptimal.

Joerg
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to