On Mon, October 31, 2011 3:30, Eli Friedman wrote: > On Mon, Oct 31, 2011 at 2:16 PM, Eli Friedman <[email protected]> wrote: >> On Sun, Oct 30, 2011 at 10:11 PM, Richard Smith >> <[email protected]> wrote: >> >>> Author: rsmith >>> Date: Mon Oct 31 00:11:32 2011 >>> New Revision: 143334 >>> >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=143334&view=rev >>> Log: >>> C++11 generalized constant expressions: evaluate equality comparisons >>> between arbitrary pointers, if those pointers don't point to weak objects >>> or literals. >> >> This patch causes constructs like the following to be constant-folded: >> >> extern char a[]; bool b = (void *) a == (void *) 0x4000UL; >> >> We don't really want to be doing that. > > I fixed this myself in r143374; please review.
Thanks! LGTM - your fix was identical to mine. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
