On Wed, Dec 14, 2011 at 10:15 PM, Argyrios Kyrtzidis <[email protected]> wrote: > On Dec 14, 2011, at 10:02 PM, David Blaikie wrote: > >> On Wed, Dec 14, 2011 at 9:53 PM, Argyrios Kyrtzidis <[email protected]> >> wrote: >>> Author: akirtzidis >>> Date: Wed Dec 14 23:53:37 2011 >>> New Revision: 146647 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=146647&view=rev >>> Log: >>> Revert r146646 that was a mistake, and make the intended change in the >>> right file. >> >> Rather than having machine-specific things why not do this the same >> way raw_os_ostream works & just use std::cerr? > > On "fatal error handler" territory I preferred to use the most direct way > without abstractions.
Fair enough - though I'm surprised it's not more portable to write a few characters to stderr. Ah well. >> >>> Log: >>> [libclang] Try to unbreak mingw build. >>> >>> Modified: >>> cfe/trunk/lib/Frontend/CompilerInstance.cpp >>> cfe/trunk/tools/libclang/CIndex.cpp >>> >>> Modified: cfe/trunk/lib/Frontend/CompilerInstance.cpp >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInstance.cpp?rev=146647&r1=146646&r2=146647&view=diff >>> ============================================================================== >>> --- cfe/trunk/lib/Frontend/CompilerInstance.cpp (original) >>> +++ cfe/trunk/lib/Frontend/CompilerInstance.cpp Wed Dec 14 23:53:37 2011 >>> @@ -48,12 +48,9 @@ >>> #include <fstream> >>> #include <sys/types.h> >>> #include <sys/stat.h> >>> -#include <cstdlib> >>> >>> #if LLVM_ON_WIN32 >>> #include <windows.h> >>> -#include <io.h> >>> -#include <fcntl.h> >>> #endif >>> #if LLVM_ON_UNIX >>> #include <unistd.h> >>> >>> Modified: cfe/trunk/tools/libclang/CIndex.cpp >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CIndex.cpp?rev=146647&r1=146646&r2=146647&view=diff >>> ============================================================================== >>> --- cfe/trunk/tools/libclang/CIndex.cpp (original) >>> +++ cfe/trunk/tools/libclang/CIndex.cpp Wed Dec 14 23:53:37 2011 >>> @@ -46,6 +46,16 @@ >>> #include "llvm/Support/Signals.h" >>> #include "llvm/Support/Threading.h" >>> #include "llvm/Support/Compiler.h" >>> +#include <cstdlib> >>> + >>> +#if LLVM_ON_WIN32 >>> +#include <windows.h> >>> +#include <io.h> >>> +#include <fcntl.h> >>> +#endif >>> +#if LLVM_ON_UNIX >>> +#include <unistd.h> >>> +#endif >>> >>> using namespace clang; >>> using namespace clang::cxcursor; >>> >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> [email protected] >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
