This prevents an error exposed by the PluginASTAction refactor:
"no analyzer checkers are associated with 'security'" (it's actually
"experimental.security"). Apparently that checker wasn't actually
being enabled by default because of this.

This does point out a problem with the current setup: Further down
in this function, the driver adds "-w" to suppress warnings,
which shuts up compiler warnings as intended, but *also* shuts up
analyzer-specific warning diagnostics like the above. Not sure
how to fix that problem.
From acad459c24383f0bbd95a10b9048398d0ca6edd9 Mon Sep 17 00:00:00 2001
From: nobled <[email protected]>
Date: Sat, 17 Dec 2011 21:17:19 +0000
Subject: [PATCH 06/19] Driver: fix name for 'security' analyzer-checker

This prevents an error exposed by the PluginASTAction refactor:
"no analyzer checkers are associated with 'security'" (it's actually
"experimental.security"). Apparently that checker wasn't actually
being enabled by default because of this.

This does point out a problem with the current setup: Further down
in this function, the driver adds "-w" to suppress warnings,
which shuts up compiler warnings as intended, but *also* shuts up
analyzer-specific warning diagnostics like the above. Not sure
how to fix that problem.
---
 lib/Driver/Tools.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp
index 798d787..54bccd0 100644
--- a/lib/Driver/Tools.cpp
+++ b/lib/Driver/Tools.cpp
@@ -1343,7 +1343,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
     if (!Args.hasArg(options::OPT__analyzer_no_default_checks)) {
       CmdArgs.push_back("-analyzer-checker=core");
       CmdArgs.push_back("-analyzer-checker=deadcode");
-      CmdArgs.push_back("-analyzer-checker=security");
+      CmdArgs.push_back("-analyzer-checker=experimental.security");
 
       if (getToolChain().getTriple().getOS() != llvm::Triple::Win32)
         CmdArgs.push_back("-analyzer-checker=unix");
-- 
1.7.4.1

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to