On Fri, Jan 13, 2012 at 1:00 AM, Evgeniy Stepanov <[email protected] > wrote:
> Hi, > > this patch removes --hash-style option from driver-generated link > command line on Android. The reason is that Android linker does not > support .gnu.hash, so the default (sysv) is the correct value. What's > worse, there is a bug in the older version of GNU ld used in the > current Android toolchain that messes up .hash section whenever > .gnu.hash is present. > Oof. This generally looks fine, feel free to commit. I would move the comment you added to be with the comment about MIPS not supporting this construct. They're both comments on the condition block, not on the IsAndroid or IsMips variables. The variables are pretty clear. =D
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
