On Tue, Jan 17, 2012 at 12:45 PM, Eli Friedman <[email protected]> wrote: > The change to lib/CodeGen/TargetInfo.cpp seems fine. The test seems > like it's overkill, since it looks like it was mostly copy-pasted; > testing a couple small functions which illustrate the significant > characteristics would suffice.
Thanks for the feedback. Attached is a revised patch that pares down
the test suite only to Win32-specific characteristics. I also found
and fixed another discrepancy with MSVC's calling convention; MSVC
returns struct {float;} and struct {double;} types in GPRs, unlike
other SmallStructABI platforms that return those types on the x87
stack. This new patch fixes and tests those cases as well.
-Joe
clang-pr11688-2.diff
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
