Hi John, OK thanks - I'm not well versed on what Darwin does and does not use. #ifndef darwin should be fine, but wouldn't it be better to conditionalise on a predefine that defines what EH mode is being used?
something like #ifdef __ARM_EH_ABI, which could be defined in the frontend depending on the eh type given on the commandline? James ________________________________________ From: John McCall [[email protected]] Sent: 19 January 2012 18:55 To: James Molloy Cc: 'Evgeniy Stepanov'; [email protected] Subject: Re: [cfe-commits] [PATCH] Extend unwind.h with the ARM unwinder interface On Jan 19, 2012, at 2:01 AM, James Molloy wrote: > Excellent, thanks. I've literally just finished talking to my colleague who > said he thought he recognised it as our example code. That's perfectly fine, > please don't add the #ifdef __linux__ as it is applicable no matter what the > OS. James, this is not true. Darwin does not use the ARM EH ABI. In general, Darwin does not follow the ARM C++ ABI except for the modifications to member function pointers, which are obligatory. Off-hand, it seems likely that there are other platforms in this situation, but at the very least the patch should be modified to exclude Darwin. John. -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
