Please ignore this review request. I screwed up the patch upload AND the description (after returning from lunch, I'd forgotten I hadn't submitted the changes I meant to have reviewed to my local git repo yet).
Thanks, Kaelyn On Mon, Jan 23, 2012 at 12:39 PM, <[email protected]> wrote: > Reviewers: kyrtzidis_apple.com, > > Description: > Previously, for unqualified lookups, a positive cache hit is used as the > only non-keyword correction and a negative cache hit immediately returns > an empty TypoCorrection. With the new callback objects, this behavior > causes false negatives by not accounting for the fact that callback > objects alter the set of potential/allowed corrections. The new behavior > is to seed the set of corrections with the cached correction (for > positive hits) to estabilishing a baseline edit distance. Negative cache > hits are only stored or used when either no callback object is provided > or when it returns true for a call to ValidateCandidate with an empty > TypoCorrection (i.e. when ValidateCandidate does not seem to be doing > any checking of the TypoCorrection, such as when an instance of the base > callback class is used solely to specify the set of keywords to be > accepted). > > Please review this at > http://codereview.appspot.com/**5570046/<http://codereview.appspot.com/5570046/> > > Affected files: > M include/clang/Parse/Parser.h > M include/clang/Sema/Sema.h > M lib/Parse/ParseExpr.cpp > M lib/Parse/ParseExprCXX.cpp > M lib/Sema/SemaExpr.cpp > M lib/Sema/SemaLookup.cpp > M test/SemaCXX/typo-correction.**cpp > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
