On Tue, 2012-01-24 at 11:03 +0100, Manuel Klimek wrote: > The attached patch adds support to run clang tools (FrontendActions) > as standalone tools, or repeatedly in-memory in a process. > This is useful for unit testing, map-reduce-style applications, source > transformation daemons, and command line tools.
I am also interested in having this kind of functionality. A few quick comments: 1. The coding standards say that function names should begin with a lower-case letter. 2. The comments contain several references to CMake; what, if anything, in this patch is tied to CMake, or designed to be compatible with CMake? 2b. > +/// \param JsonDatabase A JSON formatted list of compile commands. > This lookup > +/// command supports only a subset of the JSON standard as written by > CMake. > Please be more verbose here. What is not supported? Generally, I think that it would be helpful for you to provide a paragraph or two explaining how this extension is to be used, what kind of things can be specified in JSON inputs, how this ties into CMake (or not), etc. with a few small examples. Some of this can be gleaned from the test case, but some nicely-formatted text (without all of the escaping) would, IMHO, be earlier to read. -Hal > > Cheers, > /Manuel > > Rietveld link: > http://codereview.appspot.com/5570054/ > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits -- Hal Finkel Postdoctoral Appointee Leadership Computing Facility Argonne National Laboratory _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
