Both look great to me! On Jan 24, 2012, at 3:03 AM, Jean-Daniel Dupas wrote:
> > Le 24 janv. 2012 à 08:07, Ted Kremenek a écrit : > >> On Jan 21, 2012, at 3:49 AM, Jean-Daniel Dupas <[email protected]> >> wrote: >> >>> I have a first patch that add NSLog/NSLogv to Builtins.def, but instead of >>> adding a new letter to define NSString format attribute, I enhance the >>> AddKnownFunctionAttributes function to automatically specify "NSString" >>> format instead of "printf" format when the format parameter is an objc >>> object. >>> >>> This patch also remove trailing '/' in front of objc header names in >>> Builtins.def. It prevents message like "include </obj/objc-exception.h>" in >>> diagnostics. >> >> Looks good, but can we separate this into two separate commits? They are >> entirely orthogonal, and a patch is easier to review when it doesn't blur >> together a bunch of changes for disjoint functionality into a single commit. > > > Of course we can. If you confirm they are fine, I will commit them. > > -- Jean-Daniel > > > > <1-trailing.patch> > <2-nslog.patch>
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
