On Wed, Jan 25, 2012 at 12:15 PM, Sebastian Pop <[email protected]> wrote:
> Hi Chandler, > > On Wed, Jan 25, 2012 at 5:01 AM, Chandler Carruth <[email protected]> > wrote: > > Author: chandlerc > > Date: Wed Jan 25 05:01:57 2012 > > New Revision: 148950 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=148950&view=rev > [...] > > - > > - if (!TC && !Arch.compare ("hexagon")) { > > - llvm::Triple TCTriple (getTriple()); > > - TC = new toolchains::Hexagon_TC (getDriver(), TCTriple); > > - } > > Removing this code without adding it back to getToolChain breaks > our toolchain. Please fix. > Doh, sorry, I just missed this when scanning the host info code. Fixed in r148977. However, I'd point out that not a single test or build bot caught this. =/ At the very least we really need tests for the hexagon toolchain. You can lee test/Driver/linux-ld.c and test/Driver/linux-header-search.cpp for examples of how you can test a toolchain very thoroughly in the regression test suite. Without these types of tests, the ongoing refactoring work in the driver is very likely to break your config again. =/ A build bot for the hexagon stuff would also be amazing, but I understand the logistical challenges there.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
