Nice catch! I'm sure we didn't mean to treat -O9 as a synonym for -O1 :)
The patch looks fine. Please add a test then feel free to check in.

Thanks!
Richard

On Sun, Feb 5, 2012 at 2:52 PM, Aaron Ballman <[email protected]>wrote:

> This patch fixed 7870, where you pass in an incorrect O level on the
> command line.  The problem was that the supplied value was truncated
> to 4 bits and then being reported.  The patch simply saves the
> supplied value and assigns it after verification (or diagnostic
> output).
>
> eg)
> c:\llvm\build>clang -O900 "C:\Users\Aaron Ballman\Desktop\test.cpp"
> error: invalid value '4' in '-O900'
>
> becomes:
> c:\llvm\build>clang -O900 "C:\Users\Aaron Ballman\Desktop\test.cpp"
> error: invalid value '900' in '-O900'
>
> ~Aaron
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to