On Tue, Feb 7, 2012 at 9:07 PM, Aaron Ballman <[email protected]> wrote: > On Tue, Feb 7, 2012 at 6:36 PM, Aaron Ballman <[email protected]> wrote: >> On Tue, Feb 7, 2012 at 5:06 PM, Eli Friedman <[email protected]> wrote: >>> On Tue, Feb 7, 2012 at 5:46 AM, Aaron Ballman <[email protected]> >>> wrote: >>>> Author: aaronballman >>>> Date: Tue Feb 7 07:46:03 2012 >>>> New Revision: 149984 >>>> >>>> URL: http://llvm.org/viewvc/llvm-project?rev=149984&view=rev >>>> Log: >>>> Hex literals without a significand no longer crash the lexer. Fixes bug >>>> 7910 >>>> >>>> Patch by Eitan Adler >>>> >>>> Modified: >>>> cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td >>>> cfe/trunk/lib/Lex/LiteralSupport.cpp >>>> cfe/trunk/test/Lexer/hexfloat.cpp >>> >>> This patch breaks the following (valid) code: >>> >>> double d = 0x.2p2; >> >> Good catch -- I'll add a test case and fix it up. > > This patch should take care of the issue. I added some new test cases > based off my reading of the C99 spec. From what I could tell, we only > want to err in the case where there's no value before and no value > after the decimal.
Looks fine. -Eli _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
