Author: dblaikie Date: Thu Feb 9 23:15:16 2012 New Revision: 150230 URL: http://llvm.org/viewvc/llvm-project?rev=150230&view=rev Log: Move -Wswitch from -Wmost to -Wall, consitent with GCC.
This is a relatively noisy warning for a codebase not explicitly designed for it (effectively enforcing a stylistic constraint about the use of defaults in switches over enums) & there's nothing Clang does to clean up the noise when compared to GCC's implementation so the same decision seems suitable. Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=150230&r1=150229&r2=150230&view=diff ============================================================================== --- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original) +++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Thu Feb 9 23:15:16 2012 @@ -317,7 +317,6 @@ Reorder, ReturnType, SelfAssignment, - Switch, SizeofArrayArgument, Trigraphs, Uninitialized, @@ -331,8 +330,8 @@ // Thread Safety warnings def ThreadSafety : DiagGroup<"thread-safety">; -// -Wall is -Wmost -Wparentheses -Wdangling-else -def : DiagGroup<"all", [DanglingElse, Most, Parentheses]>; +// -Wall is -Wmost -Wparentheses -Wdangling-else -Wswitch +def : DiagGroup<"all", [DanglingElse, Most, Parentheses, Switch]>; // Aliases. def : DiagGroup<"", [Extra]>; // -W = -Wextra _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits