On Feb 13, 2012, at 4:38 PM, John McCall wrote: > On Feb 11, 2012, at 7:31 AM, Vasiliy Korchagin wrote: >> I agree, without setting implicit return zero bit changes in codegen are not >> necessary. New version of patch is attached. > > This check has nothing to do with C99. You should be checking for "has GNU > extensions" and "is not C++", i.e. > getLangOptions().GNU && !getLangOptions().CPlusPlus
I see that I missed the later follow-ups in this thread, and you're now checking CPlusPlus correctly. Please do also check for GNU extensions being enabled and implement this: > Also, please have CheckMain just set hasImplicitReturnZero() as appropriate > and then make actOnFinishFunctionBody disable fall-through checking when that > bit is set. With that, this should be fine. John. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
