On Tue, Feb 14, 2012 at 8:44 PM, Argyrios Kyrtzidis <[email protected]> wrote:
> Well, at least it doesn't change previous behavior, clang was already warning
> on "if"s with empty semicolon, so please go ahead and commit your patch, we
> can always revisit whether we should revise how this case is handled later on.
Thank you for your reviews.
Before I commit, how should I deal with the noisy false positive in
llvm/CodeGen/MachineDominators.h? Should I just commit the trivial
fix (attached) or a post to llvm-commits is necessary?
Dmitri
--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <[email protected]>*/
Index: include/llvm/CodeGen/MachineDominators.h
===================================================================
--- include/llvm/CodeGen/MachineDominators.h (revision 150502)
+++ include/llvm/CodeGen/MachineDominators.h (working copy)
@@ -84,7 +84,8 @@
// Loop through the basic block until we find A or B.
MachineBasicBlock::iterator I = BBA->begin();
- for (; &*I != A && &*I != B; ++I) /*empty*/;
+ for (; &*I != A && &*I != B; ++I)
+ /*empty*/ ;
//if(!DT.IsPostDominators) {
// A dominates B if it is found first in the basic block.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
