Feedback incorporated. Also, the comment in my previous email about
changing the get_cursor() implementation really applies to this patch.

On Fri, Feb 17, 2012 at 4:43 AM, Manuel Klimek <[email protected]> wrote:

> +    i, j = None, None
> +    for cursor in tu.cursor.get_children():
> +        if cursor.spelling == 'i':
> +            i = cursor
> +        elif cursor.spelling == 'j':
> +            j = cursor
>
> I'd reuse get_cursor from patch 2 here.
>
> Cheers,
> /Manuel
>
> On Fri, Feb 17, 2012 at 8:58 AM, Gregory Szorc <[email protected]>
> wrote:
> > ---
> >  bindings/python/tests/cindex/test_type.py |   39
> +++++++++++++++++++++++++++++
> >  1 files changed, 39 insertions(+), 0 deletions(-)
> >
> > _______________________________________________
> > cfe-commits mailing list
> > [email protected]
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>

Attachment: 0004-clang.py-Add-tests-for-Type.is_volatile_qualified-an.patch
Description: Binary data

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to