On Feb 23, 2012, at 7:27 AM, Ted Kremenek wrote: > Looks good to me. Do you have an example of the new output? > > On Feb 23, 2012, at 7:08 AM, Tom Care <[email protected]> wrote: > >> I made some changes to AnalyzerStatsChecker to make it a bit more useful. >> Changelog: >> >> Improved the information output by AnalyzerStatsChecker. In addition to >> the analysis stats for Decls, AnalyzerStatsChecker now also outputs: >> - Exhausted blocks and sinks, including their approximate location >> - Aborted blocks and their statement locations >> - When and where the analyzer reaches the max block limit >> Some supporting infrastructure changes: >> - CoreEngine now stores Stmt* with the ExplodedNode* in the aborted block >> data, since the node can change between generation and VisitEndAnalysis
My understanding is that, here, we add a bit of overhead on every analyzes run to make stats more precise. Could you elaborate/investigate a bit more on why it is absolutely necessary in this case? Is the ExplodedNode you are storing here deleted by the time you reach VisitEndAnalysis? (How is the node changed?) >> - Exposed 'block limit exceeded' tag to allow AnalyzerStatsChecker to >> detect a sink caused by exceeding the max visits for a block >> >> Regarding test cases, any test case made for this checker would break quite >> frequently as the analyzer is changed. I can't think of a good way to solve >> this. >> Would be great if you could (manually) test this with -analyzer-inline-call. >> Been a while since my last commit, so a review is much appreciated :) >> >> Tom >> <AnalyzerStatsChecker.patch>_______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
