On Mon, Feb 27, 2012 at 2:59 AM, James Molloy <[email protected]> wrote:
> Please? Anyone? Ping? :( > Sorry... I'm trying to emerge from my February rockpile... And it happens I can finish this one easily now that I have a moment... The patch looks great semantically. A couple of nit-picks. Just commit once these are fixed. =] 1) Don't set all the properties on the new test files. 2) Use the more conventional capitalized initialism loop variable naming convention: I, E, DI, DE, etc. Sorry for the mess of review, I shouldn't vanish for 4 weeks at a time...
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
