Hi Howard, On 29 Feb 2012, at 16:21, Howard Hinnant wrote:
> On Feb 29, 2012, at 8:05 AM, David Chisnall wrote: > >> libcxx/trunk/include/cmath > > Could you review your cmath commits? I've checked, and it does not break > __APPLE__. However there are some #ifdef's which do not fill me with > confidence. For example: > > #ifndef __sun__ > // abs > > #endif // __sun__ Ooops. I did have the #ifndef above the set of declarations above abs, but I moved it down since they are missing in the standard headers. Then I had to move another one up because abs isn't, and I didn't notice that the #ifndef and #endif had moved together. > If you can just search on "#" and review the matching comments, it would be > much appreciated. I think they're correct aside from that one - although I may still be hiding a few too many declarations on Solaris. Unfortunately, Sun decided to randomly put about half of the C++ things that are present in C headers in the std:: namespace, but didn't bother with the other half. David > Thanks, > Howard > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
