> Thanks, this looks fine to commit. Thanks, r151943.
>> > Other than that, a test for the fix-it would be great (see test/FixIt >> > for >> > examples). >> >> Wouldn't that require the fixit to be on the warning instead of the >> note? (If so, maybe there's no need for the test yet?) > > > You can test fixits on notes with -fdiagnostics-parseable-fixits + > FileCheck. See test/FixIt/fixit-vexing-parse.cpp for an example of that. I'm > happy for that to be a subsequent commit. Attached. I added only a test for the first fixit since having lots of line numbers hardcoded in the test would probably make the test more annoying than useful. Is this what you had in mind? Nico
clang-str-plus-int-fixit-test.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
