On Mar 19, 2012, at 8:07 AM, Nico Weber <[email protected]> wrote: > Hi Bill, > >> @@ -106,9 +107,9 @@ >> CmdArgs.push_back("."); >> } else { >> CmdArgs.push_back(ArgName); >> - CmdArgs.push_back(Args.MakeArgString(Dirs.substr(0, Delim))); >> + CmdArgs.push_back(Args.MakeArgString(Dirs.split(Delim).first)); >> } >> - Dirs = Dirs.substr(Delim + 1); >> + Dirs = Dirs.split(Delim).second; > > This broke a :-separated CPLUS_INCLUDE_PATH: > > $ CPLUS_INCLUDE_PATH="/foo:/bar" > third_party/llvm-build/Release+Asserts/bin/clang -v -c test.cc > # ... > clang -cc1 -cxx-isystem /foo:/bar ... > # ... > > I landed a fix in r153034 (I just reverted the two lines you changed > above, since they look unrelated to the change description, and > changing them made no tests fail). > Hi Nico,
That seems odd. Maybe it's a bug in StringRef? Anyway, sorry about the breakage and thanks for reverting the patch. :) -bw _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
