Jordy, This seems to implement the first suggestion by Ted, where we attempt to regenerate a single PathDiagnosticPiece, not the whole path, which would not work for state-full visitors. Am I missing something?
Anna. On Mar 20, 2012, at 4:20 PM, Jordan Rose wrote: > Thanks, Ted. Fixed and seemingly working. > > Any suggestions for alternate names for getInterestingObjectSetDescriptor()? > I'm trying to make it clear it's an opaque value that's only supposed to be > used for detecting changes... > I don't think visitors should be implementing a callback for this. You should be able to just check if the interesting symbols set in the bug reporter changed.. > <BugReporter.patch> > On Mar 20, 2012, at 15:24, Ted Kremenek wrote: > >> The plist output uses GenerateExtensivePathDiagnostic while the HTML output >> uses GenerateMinimalPathDiagnostic. Looks like you only updated one of them. >> >> On Mar 20, 2012, at 2:52 PM, Jordan Rose <[email protected]> wrote: >> >>> Okay, I have a draft implementation, but I've run into a weird problem >>> where the diagnostic about 'tmp' appears in the HTML and text output...but >>> /not/ in the plist output. Any ideas about why this might be occurring? >>> >>> <BugReporter.patch> >> > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
