On Thu, Mar 22, 2012 at 11:57 PM, Seth Cantrell <[email protected]> wrote:
> Here are some patches for review. One enables setting reverse colors with 
> raw_ostreams in LLVM. The other is to print unprintable characters in clang 
> diagnostics in hex with reversed colors.

The patch for color reversal seems fine, although maybe someone more
familiar with that code should take a look.  The patch for unprintable
characters is a step in the right direction, but completely ignores
the caret/ranges and fixits (so things won't line up).

I was actually hacking on this code from that angle recently; I'll
send you what I have soon.

-Eli
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to