Sent from my iPhone
On Mar 30, 2012, at 2:20 AM, Manuel Klimek <[email protected]> wrote: > On Thu, Mar 29, 2012 at 5:25 PM, Marshall Clow <[email protected]> wrote: >> 2) runSyntaxOnlyToolOnCode >> I don't understand why "input.cc" is hard wired here. >> Is this just some dummy file name - supposed to be unique? >> Maybe a comment to say what's going on? > > Done. > > Also, Chandler pointed out that he'd like to see this function renamed > to runToolOnCode, as users of the tooling would want syntax-only runs > to be the default (and not think about it unless they start wondering > how to run code generation as part of a map reduction). I think the name runToolOnCode better, too. Also, how about making the file name a parameter? That way, users can simply provide a different file name if it conflicts or if they want an easy way to say it's code that isn't C++ (e.g, by naming it input.c). Otherwise, I'd say this patch is ready to go in! > Thoughts? > /Manuel > <tooling.patch> _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
