On Mon, Apr 9, 2012 at 2:41 PM, Evgeniy Stepanov <[email protected]>wrote:
> Thanks! All good points. New patch attached. > LGTM. Feel free to submit and then address the ABI thing Anton mentioned. I like his idea. > > On Mon, Apr 9, 2012 at 3:00 PM, Chandler Carruth <[email protected]> > wrote: > > Sorry for missing this for a while. > > > > --- tools/clang/test/Driver/arm-as.c (revision 0) > > +++ tools/clang/test/Driver/arm-as.c (revision 0) > > > > Your change and these tests are Linux-specific, so we should put these in > > 'linux-as.c' or 'linux-arm-as.c'. I'm fine with either. > > > > +// RUN: %clang -target arm-linux -### \ > > +// RUN: -no-integrated-as -c %s 2>&1 \ > > +// RUN: | FileCheck -check-prefix=ARM %s > > +// CHECK-ARM: as" > > > > You'll need to handle 'as.exe' here I think. > > > > +// RUN: %clang -target armv7-linux "-mcpu=cortex-a8" -### \ > > > > None of the other input lines use "s. > > > > + Args.AddAllArgs(CmdArgs, options::OPT_march_EQ, options::OPT_mcpu_EQ, > > + options::OPT_mfpu_EQ); > > + > > > > Why add all of the options, shouldn't we just add the last option for > these > > (unlike -mattr)? >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
