There's no need to add a blank line at the end of CGCall.cpp, but otherwise, it looks fine to me.
On Apr 11, 2012, at 11:26 PM, Anton Korobeynikov <[email protected]> wrote: > Ping! > > On Mon, Apr 9, 2012 at 18:03, Anton Korobeynikov > <[email protected]> wrote: >> Hi Bob et al >> >> Attached patch addresses the following issues: >> >>> * More seriously, I don't see how you can get away with asserting on unions >>> in CodeGenFunction::ExpandTypeFromArgs. Am I missing something? >>> * I don't much like the code duplication for the "expand a field" code in >>> ExpandTypeToArgs. If you can get away with just grabbing the first field >>> of a union, I think you could unify that into a single loop over the fields >>> and just exit after the first iteration in the case of a union. Otherwise, >>> maybe you could factor that code out into a separate function. >> >> I do not attach the testcases once again here just to simplify the patch :) >> >> -- >> With best regards, Anton Korobeynikov >> Faculty of Mathematics and Mechanics, Saint Petersburg State University > > > > -- > With best regards, Anton Korobeynikov > Faculty of Mathematics and Mechanics, Saint Petersburg State University _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
