Hi Alex, On Thu, Apr 12, 2012 at 6:35 PM, Alexander Kornienko <[email protected]>wrote:
> Hi Richard, > > Thanks for the review. The next patch is attached. It addresses issues you > pointed out, and doxygen comments style (thanks to Chandler). > > I've also added a separate diagnostic message for wrong attributes used on > statements, and a test for it. These require some work in > Parser::ParseCXX0XAttributeSpecifier (which I didn't touch yet). > > Please, review this patch. > Thanks for all your effort! This patch looks like a great start. I've checked it in as r154723, with a couple of minor tweaks: * I shortened the wording of the diagnostic a little. * I removed the ProhibitAttributes when parsing declaration statements -- these are rejected in the appropriate circumstances in ParseDeclaration. -- Richard
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
