FWIW this seems reasonable to me. -eric
On Apr 23, 2012, at 4:14 AM, James Molloy <[email protected]> wrote: > Hi, > > Could someone please review this? :( > > Cheers, > > James > > -----Original Message----- > From: James Molloy > Sent: 19 April 2012 16:22 > To: [email protected] > Subject: FW: [cfe-commits] [PATCH] Driver: Unify CC1Options.td and > Options.td, take 2! > > Bump. > > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of James Molloy > Sent: 18 April 2012 14:42 > To: [email protected] > Subject: [cfe-commits] [PATCH] Driver: Unify CC1Options.td and Options.td, > take 2! > > Hi, > > Now that the LLVM conference is out of the way I can get back to my other > project that took a bit of a backseat, sorting out the clang driver. > > I sent this patch upstream at the start of February, and it was about to > complete code review and signoff when Chandler went away on vacation for > ages and then afterwards I had the conference so it's been gathering dust in > my patch queue for a good 2 months. > > I've rebased it to ToT and would like to have it reviewed now please :) > > Original message thread at > http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120123/052089.h > tml , with the last message here: > http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120123/052094.h > tml > > The original message says it better, but essentially this patch removes the > duplication between CC1Options.td and Options.td, and removes the namespace > separation. This is one step in the path of removing the option forwarding > from the driver for Clang and relying on CompilerInvocation for all option > [de]serialization. > > Chandler had some review comments, and my responses to those still stand > (the main one being I'll provide a followup patch to move CC1-only options > from Options.td to CC1Options.td). > > Cheers! > > James<unify-cc1options.reduced.diff><unify-cc1options.full.diff>_______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
