Mostly style nits. =] Once addressed, LGTM.
http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGClass.cpp File lib/CodeGen/CGClass.cpp (right): http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGClass.cpp#newcode1231 lib/CodeGen/CGClass.cpp:1231: CodeGenOptions::LimitedDebugInfo) { Style nit: wrap this in parens if you want unusual indentation like this... http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGExprScalar.cpp File lib/CodeGen/CGExprScalar.cpp (right): http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGExprScalar.cpp#newcode805 lib/CodeGen/CGExprScalar.cpp:805: CodeGenOptions::LimitedDebugInfo) { Same comment here. http://codereview.appspot.com/6114059/diff/1/lib/CodeGen/CGExprScalar.cpp#newcode809 lib/CodeGen/CGExprScalar.cpp:809: DI->getOrCreateRecordType(PTy->getPointeeType(), Please try to avoid trimming trailing whitespace from lines you're not changing... I only see the two here in this file, but wanted to mention it for future reference. http://codereview.appspot.com/6114059/diff/1/lib/Frontend/CompilerInvocation.cpp File lib/Frontend/CompilerInvocation.cpp (right): http://codereview.appspot.com/6114059/diff/1/lib/Frontend/CompilerInvocation.cpp#newcode1100 lib/Frontend/CompilerInvocation.cpp:1100: Args.hasArg(OPT_flimit_debug_info)) There is a helper designed for this pattern: Args.hasFlag http://codereview.appspot.com/6114059/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
