One nit: Use a semicolon rather than a comma. Otherwise, LGTM. On Fri, Apr 27, 2012 at 14:29, Nico Weber <[email protected]> wrote: > Hi, > > the attached patch changes > > test.cc:4:11: error: unexpected ':' in nested name specifier > return A:a; > ^ > :: > 1 error generated. > > to > > test.cc:4:11: error: unexpected ':' in nested name specifier, did > you mean '::'? > return A:a; > ^ > :: > 1 error generated. > > > True, there's a fixit for the '::' already, but it always takes me a > second to see that. One coworker asked for the same change. Is this > change ok? (The diagnostic is only used in one place, and always shows > the '::' fixit.) > > Nico > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
