On Fri, Apr 27, 2012 at 3:44 PM, Chad Rosier <[email protected]> wrote: > Dimitry, > > On Apr 27, 2012, at 3:20 PM, Dimitry Andric wrote: > >> On 2012-04-28 00:14, Chad Rosier wrote: >>> Author: mcrosier >>> Date: Fri Apr 27 17:14:13 2012 >>> New Revision: 155737 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=155737&view=rev >>> Log: >>> Bump up the MaxDepth in the BalancedDelimiterTracker. >>> >>> The Avida Project (http://avida.devosoft.org) exceeds the 256 limit. >>> rdar://11289131 >> >> Not only that, binutils' gold also hit this limit, as described here: >> >> http://llvm.org/bugs/show_bug.cgi?id=12480 >> >> In that bug, Pasi Parviainen also suggests another solution; but I'm not >> sure what the best approach is to fixing this properly. > > My understanding is that this limit is used to bound the amount of recursion > in the clang parser. This in turn prevents clang from blowing out its stack. > Thus, bumping the recursion depth seems like the reasonable solution.
Bumping the limit might be reasonable, or it might be papering over a real counting problem. The patch attached to the PR feels like it is fixing a real counting problem. Pogo > Hopefully, the bound is small enough to serve its purpose, but large enough >to allow projects with valid code to compile. If you wouldn't mind, please >check binutils' gold again and close the PR if this resolves the issue. > > Chad > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
