On Mon, Apr 30, 2012 at 6:43 PM, Douglas Gregor <[email protected]> wrote:

>
> On Mar 21, 2012, at 3:07 AM, Jonathan Gray <[email protected]> wrote:
>
> > In test/Driver/clang-g-opts.c with tests of the form
> >
> > // RUN: %clang -S -v -o %t %s        2>&1 | not grep -w -- -g
> >
> > using 'not' here isn't portable and doesn't work on at least
> > OpenBSD and likely other systems (bash builtin?).
> >
> > patch to move this to FileCheck attached
>
> Committed as r155874, thanks!
>

See my comments on the commit, I don't think this is a correct patch.

Move-over, 'not' *is* portable, as we build the 'not' command out of the
LLVM tree?

I fully support moving it to filecheck, but the reason as stated doesn't
comute for me.

>
>        - Doug
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to