Re: [cfe-commits] r155244 - in /cfe/trunk: include/clang/Analysis/ include/clang/StaticAnalyzer/Core/ include/clang/StaticAnalyzer/Core/BugReporter/ include/clang/StaticAnalyzer/Core/PathSensitive/ lib/Analysis/ lib/StaticAnalyzer/Core/ test/Analysis/

[Anna Zaks]

Erik,

Thanks for the review. Addressed in r156315.

Anna.
On Apr 30, 2012, at 8:19 AM, Erik Verbruggen wrote:

> 
> On Apr 20, 2012, at 23:59, Anna Zaks wrote:
> 
>> -class PostPurgeDeadSymbols : public PostStmt {
>> +/// \class Represents a point after we ran remove dead bindings BEFORE
>> +/// processing the given statement.
>> +class PreStmtPurgeDeadSymbols : public PostStmt {
>> +public:
>> +  PreStmtPurgeDeadSymbols(const Stmt *S, const LocationContext *L,
>> +                       const ProgramPointTag *tag = 0)
>> +    : PostStmt(S, PreStmtPurgeDeadSymbolsKind, L, tag) { }
> 
> Shouldn't PreStmtPurgeDeadSymbols inherit from PreStmt instead of PostStmt?
> 
> -- Erik.
> 

_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits