Hah, I see now that you just added the optimization in r157158 that I'm nagging you about removing ;)
Sent from my iPhone On May 21, 2012, at 10:27 AM, Douglas Gregor <[email protected]> wrote: > > On May 21, 2012, at 3:42 AM, Benjamin Kramer <[email protected]> wrote: > >> Author: d0k >> Date: Mon May 21 05:42:01 2012 >> New Revision: 157182 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=157182&view=rev >> Log: >> Unpack enums in CodeCompletetionResult. >> >> In theory they should be wide enough even when the enum type is signed, but >> it >> looks like MSVC9 still has problems with it. > > How about just making these 'unsigned' and using accessors, rather than > bloating this data structure on all platforms? > > Also, you'll probably want to turn the 'bool' below into an 'unsigned'. > > - Doug > >> Modified: >> cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h >> >> Modified: cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h?rev=157182&r1=157181&r2=157182&view=diff >> ============================================================================== >> --- cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h (original) >> +++ cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h Mon May 21 05:42:01 >> 2012 >> @@ -669,13 +669,13 @@ >> unsigned StartParameter; >> >> /// \brief The kind of result stored here. >> - ResultKind Kind : 3; >> + ResultKind Kind; >> >> /// \brief The cursor kind that describes this result. >> - CXCursorKind CursorKind : 16; >> + CXCursorKind CursorKind; >> >> /// \brief The availability of this result. >> - CXAvailabilityKind Availability : 8; >> + CXAvailabilityKind Availability; >> >> /// \brief Whether this result is hidden by another name. >> bool Hidden : 1; >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
