Sorry for late review...I know this has been living as a patch for a while. One 
small comment:

On May 23, 2012, at 12:29, Manuel Klimek wrote:
> +  /// \brief Accessors.
> +  /// @{
> +  std::string getFilePath() const { return FilePath; }

How about StringRef here? Avoids the copy in the case where it's going to be 
used read-only.


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to