On May 24, 2012, at 4:35 AM, Timur Iskhodzhanov wrote: > On Thu, May 24, 2012 at 2:44 PM, João Matos <[email protected]> wrote: >>>> Attached is a patch that introduces template mangling (at least in the >>>> simple cases) as well as some tests for the code. >>>> >>>> Can you please review it? >> I'm only wondering if there is any other template argument kind we need to >> handle. > We'll find out as we compile more code with Clang. > Currently, even simple programs with templates are miscompiled, the > suggested patch should cover most of the cases. > I hope all other cases will hit the assertion and then we can deal > with minimized test cases. > > The current patch (plus one more patch to handle back referenes) > mangles templates from googletest and iostream just fine (at least > without obvious problems). > >> The patch looks fine to me. > Can I commit or should I wait for John's review?
Please wait for my review; I'll get to it before the end of the week. John. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
