On Tue, May 29, 2012 at 12:46 AM, Alexey Samsonov <[email protected]>wrote:
> Hi! > > This change makes Clang driver pass only the last option from "-g" group > to the compiler: > * if it is -g0, no option is passed; > * if it is -gline-tables-only, this option is preserved; > * all other -g* options are substituted with -g. > > http://codereview.appspot.com/6243065/ > Looks good. I left a minor comment to spruce up a test. The "This is wrong." comment makes me sad. We should eventually do something along the lines of the following: 1) for all the gdb & dwarf variations collapse them to just '-g'. 2) support things like -gtoggle 3) ignore a bunch of the flag options (-gstrict-dwarf, -grecord-gcc-switches, etc) 4) produce a driver error on -gstabs, -gcoff, -gvms, etc. All the formats that Clang/LLVM doesn't support We could leave a better fixme, or if you're feeling generous, you could work on this? It shouldn't be a lot of work... > > -- > Alexey Samsonov, MSK > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
