On Tue, May 29, 2012 at 10:54 PM, Craig Topper <[email protected]>wrote:
> Author: ctopper > Date: Wed May 30 00:54:54 2012 > New Revision: 157680 > > URL: http://llvm.org/viewvc/llvm-project?rev=157680&view=rev > Log: > SSE4A should not imply LZCNT and POPCNT. FMA4 should imply SSE4A. Add > missing break at the end of btver1 feature list. > I feel like all of these should have some tests... Maybe the preprocessor predefines that result? Is there a more direct way to test? > > Modified: > cfe/trunk/lib/Basic/Targets.cpp > > Modified: cfe/trunk/lib/Basic/Targets.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=157680&r1=157679&r2=157680&view=diff > > ============================================================================== > --- cfe/trunk/lib/Basic/Targets.cpp (original) > +++ cfe/trunk/lib/Basic/Targets.cpp Wed May 30 00:54:54 2012 > @@ -1689,6 +1689,7 @@ > case CK_BTVER1: > setFeatureEnabled(Features, "ssse3", true); > setFeatureEnabled(Features, "sse4a", true); > + break; > case CK_BDVER1: > case CK_BDVER2: > setFeatureEnabled(Features, "avx", true); > @@ -1750,10 +1751,11 @@ > else if (Name == "fma4") > Features["mmx"] = Features["sse"] = Features["sse2"] = > Features["sse3"] = > Features["ssse3"] = Features["sse41"] = Features["sse42"] = > - Features["popcnt"] = Features["avx"] = Features["fma4"] = true; > + Features["popcnt"] = Features["avx"] = Features["sse4a"] = > + Features["fma4"] = true; > else if (Name == "sse4a") > Features["mmx"] = Features["sse"] = Features["sse2"] = > Features["sse3"] = > - Features["lzcnt"] = Features["popcnt"] = Features["sse4a"] = true; > + Features["sse4a"] = true; > else if (Name == "lzcnt") > Features["lzcnt"] = true; > else if (Name == "bmi") > @@ -1792,7 +1794,7 @@ > else if (Name == "avx2") > Features["avx2"] = false; > else if (Name == "sse4a") > - Features["sse4a"] = false; > + Features["sse4a"] = Features["fma4"] = false; > else if (Name == "lzcnt") > Features["lzcnt"] = false; > else if (Name == "bmi") > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
