On Jun 13, 2012, at 1:31 PM, Peter Collingbourne wrote: > On Wed, Jun 13, 2012 at 01:08:56PM -0700, Tanya Lattner wrote: >> Attached is a patch that enabled storage class specifiers static and extern >> to be allowed except static can't be used for kernel functions and variables >> in the local scope. This is new as of OpenCL 1.2. >> >> I've included a test case. >> >> Please review. > > Hi Tanya, > > We should respect the -cl-std option and only allow these storage class > specifiers if -cl-std=CL1.2.
I don't necessarily disagree, but this hasn't been done for anything regarding 1.1, so why start with 1.2? Does anyone really care about pre OpenCL-1.2 since Clang didn't really support it fully? -Tanya _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
