Hi, Meador. Now that we don't need two loops, I think it would be cleaner to use an explicit if for the first decl, then a do-while loop to process them all. That way the WarnOnEmptyTU flag goes away. (But don't forget to only warn in non-C++ mode.)
Thanks for taking care of this, Jordan On Jun 16, 2012, at 9:17 , Meador Inge <[email protected]> wrote: > Hi, > > This patch reverts the predefined decl tracking that was introduced in > r158085. It is not needed any longer after adding the change to explicitly > build __builtin_va_list types in 158592. The tests, new warning name, and > PCH behavior added in r158085 were kept. > > OK to commit? > > -- > Meador Inge > CodeSourcery / Mentor Embedded > http://www.mentor.com/embedded-software > <revert-predefine-tracking.patch> _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
