Thanks for the review. > Per the coding conventions, this should be named BackReferences (and > likewise for other variable and field declarations in the patch).
Done. > This will do different things depending on the order in which the > arguments to operator= are evaluated. I changed it to get the size in a different statement. > It looks like this will include cv-qualifiers on function parameter > types in the mangled name. That can't be right, since they're not part > of the function type. I suspect you should drop the uses of > getTypeSourceInfo() here. (This bug seems to predate your change). Well I tried dropping it, but it is needed for arrays, tests were failing without it. > We use 'cxx11' not 'cpp11' in the tests/ area to refer to C++11. Renamed. I also added a fix in the new patch for bug #12603 (http://llvm.org/bugs/show_bug.cgi?id=12603). -- João Matos
clang-MicrosoftMangling.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
