On Mon, Jun 18, 2012 at 10:35 PM, Sean Hunt <[email protected]> wrote: > On Mon, Jun 18, 2012 at 7:17 PM, Richard Smith <[email protected]> wrote: >> On Mon, Jun 18, 2012 at 1:16 PM, Aaron Ballman <[email protected]> >> wrote: >>> Here's a revised patch that takes advantage of Sean Hunt's work on >>> attributes as well (and incorporates the changes Richard suggested >>> previously). >> >> Some more small things, then please commit :) >> >>> @@ -57,7 +57,10 @@ >>> enum Syntax { >>> AS_GNU, >>> AS_CXX11, >>> - AS_Declspec >>> + AS_Declspec, >>> + // eg) __w64, __ptr32, etc. It is implied that an MSTypespec is also >>> + // a declspec. >>> + AS_MSTypespec >> >> No need to change this now, but I wonder whether we will want to >> generalize this to AS_Keyword. > > I was intending to do this. See also my patch which is about to land > and will (unfortunately) knock a bit of your work out. But don't worry > too hard about it, I'll fix it up anyway.
No worries, it was pretty trivial to handle the conflicts. I've committed in r158717. Thanks (everyone) for all the great reviews! ~Aaron _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
