Author: fjahanian
Date: Sat Jun 23 13:39:57 2012
New Revision: 159084
URL: http://llvm.org/viewvc/llvm-project?rev=159084&view=rev
Log:
objective-c: issue deprecation/unavailability warnings for methods called on
id <Protocol>. // rdar://11618852
Added:
cfe/trunk/test/SemaObjC/warn-protocol-method-deprecated.m
Modified:
cfe/trunk/lib/Sema/SemaExprObjC.cpp
Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprObjC.cpp?rev=159084&r1=159083&r2=159084&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExprObjC.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExprObjC.cpp Sat Jun 23 13:39:57 2012
@@ -2238,12 +2238,15 @@
// We allow sending a message to a qualified ID ("id<foo>"), which is ok
as
// long as one of the protocols implements the selector (if not, warn).
+ // And as long as message is not deprecated/unavailable (warn if it is).
if (const ObjCObjectPointerType *QIdTy
= ReceiverType->getAsObjCQualifiedIdType())
{
// Search protocols for instance methods.
Method = LookupMethodInQualifiedType(Sel, QIdTy, true);
if (!Method)
Method = LookupMethodInQualifiedType(Sel, QIdTy, false);
+ if (Method && DiagnoseUseOfDecl(Method, Loc))
+ return ExprError();
} else if (const ObjCObjectPointerType *OCIType
= ReceiverType->getAsObjCInterfacePointerType()) {
// We allow sending a message to a pointer to an interface (an object).
Added: cfe/trunk/test/SemaObjC/warn-protocol-method-deprecated.m
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/warn-protocol-method-deprecated.m?rev=159084&view=auto
==============================================================================
--- cfe/trunk/test/SemaObjC/warn-protocol-method-deprecated.m (added)
+++ cfe/trunk/test/SemaObjC/warn-protocol-method-deprecated.m Sat Jun 23
13:39:57 2012
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -fsyntax-only -Wno-objc-root-class -verify %s
+// rdar://11618852
+
+@protocol TestProtocol
+- (void)newProtocolMethod;
+- (void)deprecatedProtocolMethod __attribute__((deprecated)); // expected-note
2 {{method 'deprecatedProtocolMethod' declared here}}
+@end
+
+@interface NSObject @end
+
+@interface TestClass : NSObject <TestProtocol>
+
+- (void)newInstanceMethod;
+- (void)deprecatedInstanceMethod __attribute__((deprecated)); // expected-note
{{method 'deprecatedInstanceMethod' declared here}}
+
+@end
+
+int main(int argc, const char * argv[])
+{
+
+ TestClass *testObj = (TestClass*)0;
+ [testObj newInstanceMethod];
+ [testObj deprecatedInstanceMethod]; // expected-warning
{{'deprecatedInstanceMethod' is deprecated}}
+
+ [testObj newProtocolMethod];
+ [testObj deprecatedProtocolMethod]; // expected-warning
{{'deprecatedProtocolMethod' is deprecated}}
+
+ id <TestProtocol> testProto = testObj;
+ [testProto newProtocolMethod];
+ [testProto deprecatedProtocolMethod]; // expected-warning
{{'deprecatedProtocolMethod' is deprecated}}
+ return 0;
+}
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
