Hello! Thanks for review. I fixed the message. Now it has two separate forms:
* "cast from T1 to T2 discards qualifiers from pointer target type" * "cast from T1 to T2 introduces qualifiers to pointer target type in an unsafe way" Also I did some cosmetic fixes in comments, code etc. Please see attached patch. Best regards, Igor On Fri, Jun 22, 2012 at 7:48 PM, Jordan Rose <[email protected]> wrote: > I think Dmitri was specifically referring to the /message/, not the > warning itself: > > > + char** x = 0; > > + const char** y = (const char**)x; // expected-warning {{cast > > discards qualifiers from pointer target type}} > > Qualifiers are being added, not discarded. Most people won't immediately > see why this is a problem, though, so it might be worth being a bit more > verbose anyway. > > It's a good warning, thanks for putting it in. > > Jordan >
warn_cast_qual.diff
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
