On Mon, Jun 25, 2012 at 1:14 PM, Ted Kremenek <[email protected]> wrote: > On Jun 25, 2012, at 12:42 PM, Nico Weber <[email protected]> wrote: > > Hi Ted, > > On Mon, Jun 25, 2012 at 12:40 PM, Ted Kremenek <[email protected]> wrote: > > Hi Nico, > > How expensive is this check? This code makes me nervous: > > > I didn't measure, but note that this is only executed if the lhs and > rhs are both MemberExprs, and they both refer to the same Decl. This > isn't true for most assignments. > > > Makes sense. > > > Is it enough to do measure the impact on a full build of chromium, or > would you like to see more data? > > > Measuring against full build of Chromium seems reasonable to me.
Full build of the 'chrome' target with this warning on my MBP: real 31m41.500s Same clang binary at the same revision, without the warning: real 31m53.572s So the compile-time impact of the warning is below noise I'd say. Nico > It would > be nice for us to establish a common set of representative codebases to do > this kind of performance measurement on. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
