The __has_feature looks fine, but shouldn't you at least put an example in the
test case?
+class HasFeatureTest {
+#if __has_feature(attribute_unused_on_fields)
+ int unused_; // expected-warning{{private field 'unused_' is not used}}
+ int unused2_ __attribute__((unused)); // no-warning
+#endif
+};
+
I know this is already covered by other tests, but it seems weird to test
against a feature and then not use it.
Jordan
On Jun 26, 2012, at 3:06 PM, Daniel Jasper wrote:
> Can someone please review this patch?
>
> Thank you!
> Daniel
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
