I'm sorry, but for now I would ask you to not submit patches for unpublished or undocumented ABI features.
There are some very limited places where we can take patches for such features, but it's not yet clear to me that this is one. I'll talk to some others about this particular instance. We're still working out some aspects of the Windows support strategy for Clang, but it would help a lot to focus efforts on fixing correctness issues with the published (on MSDN) ABI specifications. On Tue, Jun 26, 2012 at 11:25 PM, João Matos <[email protected]>wrote: > Chandler, most of the details of the MS ABI are not publicly > documented, as far as I know there is no spec. > > The only reference I can find is this: > http://msdn.microsoft.com/en-us/library/ff798096.aspx > > On Wed, Jun 27, 2012 at 7:13 AM, Chandler Carruth <[email protected]> > wrote: > > Can you include a citation of the spec you're basing the contents of the > > patch off of please? > > > > > > On Mon, Jun 25, 2012 at 2:36 PM, João Matos <[email protected]> > wrote: > >> > >> AFAIK this is independent of bitness. It's just the equivalent of > >> "__cxa_pure_virtual" in the Itanium ABI and is used also in the 64bit > >> MS ABI. > >> > >> On Mon, Jun 25, 2012 at 10:19 PM, Chandler Carruth < > [email protected]> > >> wrote: > >> > On Sun, Jun 24, 2012 at 5:43 PM, João Matos <[email protected]> > >> > wrote: > >> >> > >> >> Attached is a patch that abstract the virtual pure call C++ ABI. It > >> >> also implements the correct one for the MS ABI. > >> > > >> > > >> > What ABI are you basing this on? > >> > > >> > Currently, Clang is focused on Win64 support based on the published > >> > win64 > >> > ABI specs, so it may take some time for this patch to get reviewed > >> > otherwise... > >> > >> > >> > >> -- > >> João Matos > > > > > > > > -- > João Matos >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
