ping

On Wed, Jun 13, 2012 at 12:10 PM, Evgeniy Stepanov
<[email protected]> wrote:
> ping
>
> On Fri, Jun 8, 2012 at 2:03 PM, Evgeniy Stepanov
> <[email protected]> wrote:
>> ping
>>
>> On Mon, Jun 4, 2012 at 7:35 PM, Evgeniy Stepanov
>> <[email protected]> wrote:
>>> Oops.
>>> Please take another look.
>>>
>>> On Mon, Jun 4, 2012 at 7:11 PM, Benjamin Kramer
>>> <[email protected]> wrote:
>>>>
>>>> On 04.06.2012, at 17:00, Evgeniy Stepanov wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> this patch adds detection of C++ headers and libraries paths when
>>>>> building with the standalone toolchain from Android NDK. They are in a
>>>>> slightly unusual place.
>>>>>
>>>>> Please review.
>>>>
>>>>> const Twine IncludePathCandidates[] = {
>>>>
>>>> You can't store an array of Twines. The class relies on temporary objects 
>>>> which are destroyed at the end of the statement. The compiler can chose to 
>>>> reallocate the memory of the temporary and your code will fail.
>>>>
>>>> - Ben
>>>>> <android-standalone.patch>_______________________________________________
>>>>> cfe-commits mailing list
>>>>> [email protected]
>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to